[MNG-8678] Address review: improve isFatal Javadoc and add soft-failure test - #13091
Merged
Conversation
…re test Follow-up to apache#13055. The isFatal Javadoc @return tag now explains why RuntimeException is treated as fatal on par with Error (both indicate an unexpected JVM or framework state). A new test pins the soft-failure path so a future change to isFatal cannot silently break --fail-at-end for ordinary plugin failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #13055 and the review on #13067.
Two improvements to
BuildPlanExecutor:Javadoc clarification
The
isFatal@returntag now explains whyRuntimeExceptionis treated as fatal on par withError: both indicate an unexpected JVM or framework state, as opposed to checked exceptions which are ordinary plugin failures that allow the reactor to continue.New test: soft-failure path
exceptionThrownByBuildStepIsRecordedAsBuildFailureusesIllegalStateException(aRuntimeException, fatal path). There was no test pinning the soft-failure path — a checked exception that must not halt the reactor when--fail-at-endis in effect. The newcheckedExceptionThrownByBuildStepDoesNotHaltReactortest fills that gap.